fix(filterFilter): don't interpret dots in predicate object fields as…

… paths Closes angular#6005 Closes angular#6009
caitp · Jan 31, 2014 · 339a165 · 339a165
1 parent 29432ff
commit 339a165
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/ng/filter/filter.js b/src/ng/filter/filter.js
@@ -188,7 +188,7 @@ function filterFilter() {
           (function(path) {
             if (typeof expression[path] == 'undefined') return;
             predicates.push(function(value) {
-              return search(path == '$' ? value : getter(value, path), expression[path]);
+              return search(path == '$' ? value : (value && value[path]), expression[path]);
             });
           })(key);
         }

diff --git a/test/ng/filter/filterSpec.js b/test/ng/filter/filterSpec.js
@@ -60,6 +60,16 @@ describe('Filter: filter', function() {
     expect(filter(items, {first:'misko', last:'hevery'})[0]).toEqual(items[0]);
   });
 
+
+  it('should support predicat object with dots in the name', function() {
+    var items = [{'first.name': 'misko', 'last.name': 'hevery'},
+                 {'first.name': 'adam', 'last.name': 'abrons'}];
+
+    expect(filter(items, {'first.name':'', 'last.name':''}).length).toBe(2);
+    expect(filter(items, {'first.name':'misko', 'last.name':''})).toEqual([items[0]]);
+  });
+
+
   it('should match any properties for given "$" property', function() {
     var items = [{first: 'tom', last: 'hevery'},
                  {first: 'adam', last: 'hevery', alias: 'tom', done: false},