Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(canary): support use cookie value and pattern #8

Merged
merged 2 commits into from
Mar 25, 2020
Merged

feat(canary): support use cookie value and pattern #8

merged 2 commits into from
Mar 25, 2020

Conversation

whalecold
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@caicloud-bot caicloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2020
@caicloud-bot
Copy link

@whalecold: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository.

@caicloud-bot caicloud-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2020
@whalecold whalecold changed the title WIP: feat(canary): support use cookie value and pattern feat(canary): support use cookie value and pattern Mar 24, 2020
@caicloud-bot caicloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2020
@whalecold
Copy link
Member Author

/release-note-none

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 25, 2020
@whalecold
Copy link
Member Author

ping @hanxueluo @qianlei90

@hanxueluo
Copy link

LGTM

@whalecold
Copy link
Member Author

@hezhizhen

@hezhizhen
Copy link

LGTM

@qianlei90
Copy link

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@whalecold
Copy link
Member Author

/approve

@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qianlei90, whalecold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qianlei90, whalecold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot merged commit 6c9f81e into caicloud:nginx-0.23-caicloud Mar 25, 2020
hanxueluo pushed a commit that referenced this pull request Jan 5, 2021
@whalecold
feat(canary): support use cookie value and pattern (#8)
d7c1bf4 
* feat(canary): support use cookie value

* feat: support use cookie pattern

Co-authored-by: Lisheng Zheng <zhenglisheng@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@qianlei90 qianlei90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whalecold @caicloud-bot @hanxueluo @hezhizhen @qianlei90