-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config updates for dbt #353
Conversation
The error message here says "('flags' was unexpected)"...maybe the dbt version in the repo is too low for this change? It looks like Comparing to caltrans, where this change worked:
|
Thank you for flagging James! |
Had to make several updates to address errors i ran into which are captured in the following articles: |
this is ready for another review and merge @JamesSLogan |
the sql fluff errors are not actual errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@britt-allen thanks for getting package versions up-to-date. It's weird that sqlfluff is throwing false negatives for those CTEs, it seems like a bug...I disabled that specific test so that CI will pass. Feel free to merge unless you see an issue with this approach
Thank you for demonstrating how to silence those @JamesSLogan! |
@JamesSLogan @britt-allen @tnrahim Is this related to the issue Taheer was helping CARB with earlier in the week? |
I don't know. What's up? @jkarpen |
@britt-allen Not sure, could be a totally different issue. Just flagging for Taheer in case there is anything relevant to apply. |
fixes #352