Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config updates for dbt #353

Merged
merged 9 commits into from
Aug 22, 2024
Merged

config updates for dbt #353

merged 9 commits into from
Aug 22, 2024

Conversation

britt-allen
Copy link
Contributor

fixes #352

@britt-allen britt-allen self-assigned this Aug 21, 2024
@JamesSLogan
Copy link
Contributor

The error message here says "('flags' was unexpected)"...maybe the dbt version in the repo is too low for this change? It looks like 1.6.0 is getting installed.

Comparing to caltrans, where this change worked:

repo string in pyproject.toml installed version from CI logs
data-infrastructure dbt-core = "~1.6" 1.6.0
caltrans dbt-core = "~1.7.0" 1.7.18

@britt-allen
Copy link
Contributor Author

Thank you for flagging James!

@britt-allen
Copy link
Contributor Author

@britt-allen
Copy link
Contributor Author

this is ready for another review and merge @JamesSLogan

@britt-allen
Copy link
Contributor Author

the sql fluff errors are not actual errors

Copy link
Contributor

@JamesSLogan JamesSLogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@britt-allen thanks for getting package versions up-to-date. It's weird that sqlfluff is throwing false negatives for those CTEs, it seems like a bug...I disabled that specific test so that CI will pass. Feel free to merge unless you see an issue with this approach

@britt-allen
Copy link
Contributor Author

Thank you for demonstrating how to silence those @JamesSLogan!

@britt-allen britt-allen merged commit 8ff7bdc into main Aug 22, 2024
4 checks passed
@jkarpen
Copy link
Collaborator

jkarpen commented Aug 22, 2024

@JamesSLogan @britt-allen @tnrahim Is this related to the issue Taheer was helping CARB with earlier in the week?

@britt-allen
Copy link
Contributor Author

I don't know. What's up? @jkarpen

@jkarpen
Copy link
Collaborator

jkarpen commented Aug 22, 2024

@britt-allen Not sure, could be a totally different issue. Just flagging for Taheer in case there is anything relevant to apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move profile config to avoid deprecation warning
3 participants