art314 upgrades for OscLib #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- addressing #19 - nulite v3_16_04a carries latest art 3.14.04 upgrade - thus new qualifier n316 - new root and boost, with updated p3915 python qualifier - e26 and c14 exist for this upgrade atm
- remove older flavours of nutools from build options (n313) - add new build options, e26, c14 - update README with more recent version numbers. specifically this is effort to upgrade to use `art v3_14_04`. this aligns with `root v6_28_12`; addresses a seg fault in prior `v6_28_10b` when fitting a TH1F [redmine bug 28651](https://cdcvs.fnal.gov/redmine/issues/28651).
- nova is still using n313
- deprecated-declarations - maybe-uninitialized The first is a deprecation that is pulled in by `boost`: `struct std::iterator is deprecated` --> [SO: why is stditerator deprecated](https://stackoverflow.com/questions/43268146/why-is-stditerator-deprecated). Since we have `-Werror`, need to flag these couple of warnings to be able to proceed. The latter warning is from Eigen: ``` error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized] 229 | internal::selfadjoint_matrix_vector_product<Scalar, Index, (internal::traits<ActualLhsTypeCleaned>::Flags&RowMajorBit) ? RowMajor : ColMajor, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 230 | int(LhsUpLo), bool(LhsBlasTraits::NeedToConjugate), bool(RhsBlasTraits::NeedToConjugate)>::run | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 231 | ( | ^ 232 | lhs.rows(), // size | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 233 | &lhs.coeffRef(0,0), lhs.outerStride(), // lhs info | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 234 | actualRhsPtr, // rhs info | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 235 | actualDestPtr, // result info | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 236 | actualAlpha // scale factor | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 237 | ); | ~ ```
- `eigen` version is now `v23_08_01_66e8f` for `art 314` series
- responding to https://cdcvs.fnal.gov/redmine/issues/28782, dropping back to older eigen. Newer eigen gives build errors. See #19 - update jenkins table matrix for builds to attempt.
chenel
approved these changes
Jul 2, 2024
|
Hello! @gavinsdavies any updates on when these are expected to be merged in, and when a new osclib tag will be issued? |
|
i can merge these in now and cut osclib tag. then we can see what else is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBN requested new build of OscLib (#19 ) with the c14/e26 qualifiers.
had to lower error threshold for now (revisit) and continue using
eigen v3_4_0.this should address the request.
I'll need to make some tweaks on jenkins to get it to build over there; making it run in a container.
making spack-ified versions will be next on the menu but not to be mixed with this request.