Bypass VRaptor filter in WebSocket requests. #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2014 14:59
2. Creation of a unit test for the Websocket request bypass mechanism.
|
Garcia, please take a look at this new version of the code. I also provided a unit test along with the implementation. As an enhancement, I changed the comparison logic from equals() to contains() as the Websocket spec states that: |
| @@ -104,7 +104,13 @@ public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain) | |||
|
|
|||
| final HttpServletRequest baseRequest = (HttpServletRequest) req; | |||
| final HttpServletResponse baseResponse = (HttpServletResponse) res; | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Since you have isWebsocketRequest you don't need the comment because the method name already did what's happening.
|
I think that both the code and the test look much better now. Please advise. |
|
It sounds nice to me. Thanks @marcioferlan. |
Turini
added a commit
that referenced
this pull request
Nov 24, 2014
Bypass VRaptor filter in WebSocket requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to open a WebSocket connection to a @serverendpoint component in your application, the current implementation of the VRaptor filter prevents it from completing.
This fix allows WebSocket requests to bypass the VRaptor filter, hence, succeeding to establish the connection.