Refactoring internal API to use modern Java APIs #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hashtable is too old and its prefered to use HashMap instead Hashtable. Has no reason to use Hashtable here. And GsonDeserializer can use Charset instead of String charset name, that is preferable in Java 6+.
According JLS all comparators should implements Serializable and overriding equals and hashcode methods.
Because I18nParam class is stored in a serializable class, so must be serializable too.
garcia-jj
changed the title
garcia-jj
added a commit
that referenced
this pull request
Nov 17, 2014
Refactoring internal API to use modern Java APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashtableis too old and its prefered to useHashMap. Has no reason to useHashtablehere. And GsonDeserializer can useCharsetinstead ofStringcharset name, that is preferable in Java 6+.Plus: some minor changes that violates JLS like transient values stored into serializable objects, possible InputStream leaks, comparators without serialization, and more.