Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for download files as zip archive #807

Merged
merged 5 commits into from
Sep 23, 2014

Conversation

garcia-jj
Copy link
Member

Closes #802. Allow users to return files as compressed zip archives.

Right now we are in freezing time until next final release, so I think this pull request can be merged only before final release.

@Turini
Copy link
Member

Turini commented Sep 22, 2014

sounds nice, thanks! it'd be nice some docs about it :)

@garcia-jj
Copy link
Member Author

Some limitations for this component:

  • Files are compressed on the fly. So we can't return the final zip file size. Download bar in browser can't calculate download time.
  • Too large files like many gigabytes can throws an OutOfMemory because we don't flush the stream. I don't know if we can take care with this case, because sounds too fancy compress these kind of files on the fly.
  • Compression level is the default. We need to expose some method to allow users to override then? For me sounds like unnecessary.
  • In the DownloadBuilder, methods like setContentType are exposed, but without any effect. Due we can't reduce method visibility in child classes, we are only ignoring the method if called.

@garcia-jj
Copy link
Member Author

@Turini docs added. Sorry if has errors, I'm editing in web mobile editor.

@Turini
Copy link
Member

Turini commented Sep 23, 2014

sounds great! Since this is just the builder and docs, I think we can merge before the
final... can you just replace REPLACE_ME_ON_NEXT_RELEASE for 4.1 before merging? tks

@garcia-jj
Copy link
Member Author

Done. Thank you.

garcia-jj added a commit that referenced this pull request Sep 23, 2014
Support for download files as zip archive
@garcia-jj garcia-jj merged commit f39cebf into master Sep 23, 2014
@garcia-jj garcia-jj deleted the ot-gh802-compresseddownload branch September 23, 2014 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to allow users to download files as zip
2 participants