checking if result is used on DefaultLogicResult #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a legacy code from vr3, may @lucascs wants to see. For me, everything right. |
| logger.debug("Forwarding to {}", path); | ||
| request.getRequestDispatcher(path).forward(request, response); | ||
| if (response.isCommitted() || result.used()) { | ||
| return null; |
|
done, thks! |
Turini
added a commit
that referenced
this pull request
Sep 22, 2014
checking if result is used on DefaultLogicResult
| String path = resolver.pathFor(DefaultControllerMethod.instanceFor(type, method)); | ||
| logger.debug("Forwarding to {}", path); | ||
| request.getRequestDispatcher(path).forward(request, response); | ||
| if (response.isCommitted() || result.used()) { |
There was a problem hiding this comment.
result.used() always returns true.. no more forward :(
There was a problem hiding this comment.
You're right! 💣 💣 💣
Do you want to open a pull request fixing this?
There was a problem hiding this comment.
Is it really needed checking for result.used() ?
Atual VRaptor's version probably is breanking many application since forward isn't working.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #778