Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolating with the current locale #790

Merged
merged 2 commits into from
Sep 11, 2014
Merged

Conversation

Turini
Copy link
Member

@Turini Turini commented Sep 10, 2014

Closes #788.

@Turini Turini added the bug label Sep 10, 2014
@Turini Turini self-assigned this Sep 10, 2014
@lucascs
Copy link
Member

lucascs commented Sep 11, 2014

Will this solve the case in which the user sets the locale on the jsp?

@garcia-jj
Copy link
Member

I don't understand, because the current code on master works fine for me, getting Locale from JSTL (using web.xml config) as describe in our docs.

The problem by issue #788 don't works because when we interpolate the message, the view was not called yet. So fmt:setLocale was not setted the locale.

@Turini
Copy link
Member Author

Turini commented Sep 11, 2014

Will this solve the case in which the user sets the locale on the jsp?

Yes, it should. On my tests it's working like a charm.

@garcia-jj did you test with this change?

Turini added a commit that referenced this pull request Sep 11, 2014
interpolating with the current locale
@Turini Turini merged commit a58f7bb into master Sep 11, 2014
@Turini Turini deleted the i18ningValidationMessages branch September 11, 2014 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I18n in Bean Validation messages
3 participants