Adding feature to configure upload size with annotation

[garcia-jj]

Because there are some times we want to configure upload size with different values for another method. Or we want to configure a value without overriding a class.

If you like it, I'll add documentation.

[rponte]

Nice and useful feature!

On Fri, Sep 5, 2014 at 4:33 AM, Otávio Garcia notifications@github.com
wrote:

Because there are some times we want to configure upload size with
different values for another method. Or we want to configure a value
without overriding a class.

If you like it, I'll add documentation.

You can merge this Pull Request by running

git pull https://github.com/caelum/vraptor4 ot-uploadsize

Or view, comment on, or merge it at:

#785
Commit Summary

• Extracting upload size to class constants
• Adding getAnnotation method to ControllerMethod
• Adding feature to configure upload size with annotation
• Fixing indentation

File Changes

• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/controller/ControllerMethod.java
  https://github.com/caelum/vraptor4/pull/785/files#diff-0 (2)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/controller/DefaultControllerMethod.java
  https://github.com/caelum/vraptor4/pull/785/files#diff-1 (5)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/observer/upload/CommonsUploadMultipartObserver.java
  https://github.com/caelum/vraptor4/pull/785/files#diff-2 (7)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/observer/upload/DefaultMultipartConfig.java
  https://github.com/caelum/vraptor4/pull/785/files#diff-3 (5)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/observer/upload/MultipartConfig.java
  https://github.com/caelum/vraptor4/pull/785/files#diff-4 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/observer/upload/CommonsUploadMultipartObserverTest.java
  https://github.com/caelum/vraptor4/pull/785/files#diff-5 (64)

Patch Links:

• https://github.com/caelum/vraptor4/pull/785.patch
• https://github.com/caelum/vraptor4/pull/785.diff

—
Reply to this email directly or view it on GitHub
#785.

Rafael Ponte
TriadWorks | Formação Java
http://cursos.triadworks.com.br

[Turini]

what do you think of changing to event.getMethodAnnotation(...)?

[garcia-jj]

I don't think so because we already have a method called getAnnotations. Because of this, I think that methods needs to get the same name pattern.

[Turini]

so event.getAnnotation(...)...

[Turini]

only missing docs, after adding it

[garcia-jj]

Right. I'll soon. Thank you.

[garcia-jj]

@Turini @lucascs I did some docs changes about this feature, only in english until now. What you think? 6ce19e2

[garcia-jj]

I have changed some words in the docs to make it more easily to understand. Let me know if the text are good, or if need more improvements. Thank you devs.