Extracting exception key to constant

[garcia-jj]

Extracting converter exception keys to a constant allow users to see which keys are used in ResourceBundle, because Javadocs generate a page called "Constant Field Values".

When I refactor the code I see some wrong messages like not_a_valid_interger to a Short, Byte and Long converters. So I choose to use always not_a_valid_number as used by byte, BigDecimal, Double and Float uses. What you think about this change, devs?

[rponte]

It's fair!

On Monday, September 1, 2014, Otávio Garcia notifications@github.com
wrote:

Extracting converter exception keys to a constant allow users to see which
keys are used in ResourceBundle, because Javadocs generate a page called
"Constant Field Values".

When I refactor the code I see some wrong messages like
not_a_valid_interger to a Short, Byte and Long converters. So I choose to
use always not_a_valid_number as used by byte, BigDecimal, Double and

Float uses. What you think about this change, devs?

You can merge this Pull Request by running

git pull https://github.com/caelum/vraptor4 ot-fixingconverters

Or view, comment on, or merge it at:

#772
Commit Summary

• Extracting exception key to constant
• Fixing wrong message keys

File Changes

• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/BigDecimalConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-0 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/BigIntegerConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-1 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/BooleanConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-2 (5)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/ByteConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-3 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/CalendarConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-4 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/CharacterConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-5 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/DateConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-6 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/DoubleConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-7 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/EnumConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-8 (8)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/FloatConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-9 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/IntegerConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-10 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/LongConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-11 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveByteConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-12 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveCharConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-13 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveDoubleConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-14 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveFloatConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-15 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveIntConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-16 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveLongConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-17 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/PrimitiveShortConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-18 (4)
• M
  vraptor-core/src/main/java/br/com/caelum/vraptor/converter/ShortConverter.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-19 (4)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/BigIntegerConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-20 (4)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/ByteConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-21 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/IntegerConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-22 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/LongConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-23 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/PrimitiveByteConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-24 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/PrimitiveIntConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-25 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/PrimitiveLongConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-26 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/PrimitiveShortConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-27 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/converter/ShortConverterTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-28 (2)
• M
  vraptor-core/src/test/java/br/com/caelum/vraptor/http/iogi/IogiParametersProviderTest.java
  https://github.com/caelum/vraptor4/pull/772/files#diff-29 (2)
• M vraptor-core/src/test/resources/messages.properties
  https://github.com/caelum/vraptor4/pull/772/files#diff-30 (1)

Patch Links:

• https://github.com/caelum/vraptor4/pull/772.patch
• https://github.com/caelum/vraptor4/pull/772.diff

—
Reply to this email directly or view it on GitHub
#772.

Rafael Ponte
TriadWorks | Formação Java
http://cursos.triadworks.com.br

[Turini]

good point, +1 changing it (but maybe we should add a changelog note)