Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently handle superclass/subclass converters independent of class load order. #1060

Merged
merged 2 commits into from
Apr 17, 2016
Merged

Consistently handle superclass/subclass converters independent of class load order. #1060

merged 2 commits into from
Apr 17, 2016

Conversation

sbell8-chwy
Copy link

@sbell8-chwy sbell8-chwy mentioned this pull request Apr 1, 2016
Closed
@Turini
Copy link
Member

Turini commented Apr 5, 2016

hey @smbell,
I'll try and review this code soon to provide you a feedback, ok?
this all sounds great, btw. thx

@Turini
Copy link
Member

Turini commented Apr 17, 2016

sounds to work like a charm. I'll try in a large app soon, merging by now. Thx again

@Turini Turini merged commit 6f7f7e1 into caelum:master Apr 17, 2016
@sbell8-chwy
Copy link
Author

Great! My first actual open source contribution. :)

@Turini
Copy link
Member

Turini commented Apr 18, 2016

Wow, it's an honor to us!
Welcome on board, @smbell. I'm looking forward for your next pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbell8-chwy @Turini