squid:S2325 - "private" methods that dont access instance data should…

vraptor-core/src/main/java/br/com/caelum/vraptor/converter/BooleanConverter.java

@@ -65,7 +65,7 @@ public Boolean convert(String value, Class<? extends Boolean> type) {
 		throw new ConversionException(new ConversionMessage(INVALID_MESSAGE_KEY, value));
 	}
 
-	private boolean matches(Set<String> words, String value) {
+	private static boolean matches(Set<String> words, String value) {
 		return words.contains(value);
 	}
 }

vraptor-core/src/main/java/br/com/caelum/vraptor/core/DefaultExceptionMapper.java

@@ -87,7 +87,7 @@ public ExceptionRecorder<Result> findByException(Exception e) {
 		return hasExceptionCause(e) ? findByException((Exception) e.getCause()) : null;
 	}
 
-	private boolean hasExceptionCause(Exception e) {
+	private static boolean hasExceptionCause(Exception e) {
 		return e.getCause() != null && e.getCause() instanceof Exception;
 	}
 }

vraptor-core/src/main/java/br/com/caelum/vraptor/core/DefaultStaticContentHandler.java

@@ -69,14 +69,14 @@ private String uriRelativeToContextRoot(HttpServletRequest request) {
 		return removeQueryStringAndJSessionId(uri);
 	}
 
-	private String removeQueryStringAndJSessionId(String uri) {
+	private static String removeQueryStringAndJSessionId(String uri) {
 		if (uri.contains("?") || uri.contains(";")) {
 			return uri.replaceAll("[\\?;].+", "");
 		}
 		return uri;
 	}
 
-	private boolean isAFile(URL resourceUrl) {
+	private static boolean isAFile(URL resourceUrl) {
 		return !resourceUrl.toString().endsWith("/");
 	}
 

vraptor-core/src/main/java/br/com/caelum/vraptor/environment/DefaultEnvironment.java

@@ -136,15 +136,15 @@ public String run() {
 	/**
 	 * Find environment name using {@code VRAPTOR_ENV} from system environment.
 	 */
-	private String fromSystemEnv() {
+	private static String fromSystemEnv() {
 		return System.getenv("VRAPTOR_ENV");
 	}
 
 	/**
 	 * Find environment name using {@code br.com.caelum.vraptor.environment} from system property. To define this
 	 * you can start the application server using {@code -Dbr.com.caelum.vraptor.environment=DEVELOPMENT}.
 	 */
-	private String fromSystemProperty() {
+	private static String fromSystemProperty() {
 		return System.getProperty(ENVIRONMENT_PROPERTY);
 	}
 

vraptor-core/src/main/java/br/com/caelum/vraptor/http/route/DefaultRouteBuilder.java

@@ -207,7 +207,7 @@ private void addParametersInfo(Method method) {
 		}
 	}
 
-	private String[] sanitize(String[] parameters) {
+	private static String[] sanitize(String[] parameters) {
 		String[] sanitized = new String[parameters.length];
 		for (int i = 0; i < parameters.length; i++) {
 			sanitized[i] = parameters[i].replaceAll("(\\:.*|\\*)$", "");

vraptor-core/src/main/java/br/com/caelum/vraptor/http/route/PathAnnotationRoutesParser.java

@@ -173,7 +173,7 @@ protected String[] getUris(Method javaMethod){
 			return new String[0];
 		}
 		return (String[]) reflectionProvider.invoke(method, "value");
-	}
+	}
 
 	protected void fixURIs(Class<?> type, String[] uris) {
 		String prefix = extractPrefix(type);
@@ -202,7 +202,7 @@ protected String extractPrefix(Class<?> type) {
 		}
 	}
 
-	private String fixLeadingSlash(String uri) {
+	private static String fixLeadingSlash(String uri) {
 		if (!uri.startsWith("/")) {
 			return  "/" + uri;
 		}

vraptor-core/src/main/java/br/com/caelum/vraptor/observer/DeserializingObserver.java

@@ -103,7 +103,7 @@ public void deserializes(@Observes InterceptorsReady event, HttpServletRequest r
 		}
 	}
 
-	private String mime(String contentType) {
+	private static String mime(String contentType) {
 		if (contentType.contains(";")) {
 			return contentType.split(";")[0];
 		}

vraptor-core/src/main/java/br/com/caelum/vraptor/observer/download/FileDownload.java

@@ -65,7 +65,7 @@ public void write(HttpServletResponse response) throws IOException {
 		}
 	}
 
-	private File checkFile(File file) throws FileNotFoundException {
+	private static File checkFile(File file) throws FileNotFoundException {
 		if (!file.exists()) {
 			throw new FileNotFoundException("File " + file.getName() + " doesn't exists");
 		}

vraptor-core/src/main/java/br/com/caelum/vraptor/serialization/DefaultDeserializers.java

@@ -64,7 +64,7 @@ private Deserializer subpathDeserializerForPlus(String contentType, Container co
 		return null;
 	}
 
-	private String removeChar(String type, String by) {
+	private static String removeChar(String type, String by) {
 		return type.substring(type.lastIndexOf(by)+1);
 	}
 

vraptor-core/src/main/java/br/com/caelum/vraptor/serialization/gson/GsonDeserialization.java

@@ -157,7 +157,7 @@ public Object[] deserialize(InputStream inputStream, ControllerMethod method) {
 		return values;
 	}
 
-	private Type fallbackTo(Type parameterizedType, Class<?> type) {
+	private static Type fallbackTo(Type parameterizedType, Class<?> type) {
 		if (parameterizedType instanceof TypeVariable) return type;
 		return parameterizedType;
 	}
@@ -174,7 +174,7 @@ private String getRequestCharset() {
 		return charset.split(",")[0];
 	}
 
-	private boolean isWithoutRoot(Parameter[] parameters, JsonObject root) {
+	private static boolean isWithoutRoot(Parameter[] parameters, JsonObject root) {
 		for (Parameter parameter : parameters) {
 			if (root.get(parameter.getName()) != null)
 				return false;
@@ -192,7 +192,7 @@ protected Class<?>[] getTypes(ControllerMethod method) {
 		return parameterTypes;
 	}
 
-	private Class<?>[] parseGenericParameters(Class<?>[] parameterTypes,
+	private static Class<?>[] parseGenericParameters(Class<?>[] parameterTypes,
 			Type genericType) {
 		Class<?> type = (Class<?>) getGenericType(genericType);
 		for (int i = 0; i < parameterTypes.length; i++) {
@@ -203,7 +203,7 @@ private Class<?>[] parseGenericParameters(Class<?>[] parameterTypes,
 		return parameterTypes;
 	}
 
-	private Type getGenericSuperClass(ControllerMethod method) {
+	private static Type getGenericSuperClass(ControllerMethod method) {
 		Type genericType = method.getController().getType().getGenericSuperclass();
 		if (genericType instanceof ParameterizedType) {
 			return genericType;
@@ -212,7 +212,7 @@ private Type getGenericSuperClass(ControllerMethod method) {
 		return null;
 	}
 
-	private Type getGenericType(Type type) {
+	private static Type getGenericType(Type type) {
 		ParameterizedType paramType = (ParameterizedType) type;
 		return paramType.getActualTypeArguments()[0];
 	}

vraptor-core/src/main/java/br/com/caelum/vraptor/serialization/xstream/VRaptorClassMapper.java

@@ -77,7 +77,7 @@ public boolean shouldSerializeMember(Class definedIn, String fieldName) {
 		return should;
 	}
 
-	private boolean isCompatiblePath(Entry<String, Class<?>> path, Class definedIn, String fieldName) {
+	private static boolean isCompatiblePath(Entry<String, Class<?>> path, Class definedIn, String fieldName) {
 		return path.getValue().equals(definedIn) && (path.getKey().equals(fieldName) || path.getKey().endsWith("." + fieldName));
 	}
 

vraptor-core/src/main/java/br/com/caelum/vraptor/serialization/xstream/XStreamXMLDeserializer.java

@@ -85,7 +85,7 @@ public XStream getConfiguredXStream(Method javaMethod, Class<?>[] types) {
 		return xStream;
 	}
 
-	private void chooseParam(Class<?>[] types, Object[] params, Object deserialized) {
+	private static void chooseParam(Class<?>[] types, Object[] params, Object deserialized) {
 		for (int i = 0; i < types.length; i++) {
 			if (types[i].isInstance(deserialized)) {
 				params[i] = deserialized;

vraptor-core/src/main/java/br/com/caelum/vraptor/view/DefaultAcceptHeaderToFormat.java

@@ -176,7 +176,7 @@ private MimeType convertToMimeType(String string) {
 		return new MimeType(string, 1);
 	}
 
-	private double extractQualifier(String string) {
+	private static double extractQualifier(String string) {
 		double qualifier = DEFAULT_QUALIFIER_VALUE;
 		if (string.contains("q=")) {
 			Matcher matcher = Pattern.compile("\\s*q=(.+)\\s*").matcher(string);

vraptor-core/src/main/java/br/com/caelum/vraptor/view/DefaultPathResolver.java

@@ -88,7 +88,7 @@ protected String extractControllerFromName(String baseName) {
 		return baseName;
 	}
 
-	private String lowerFirstCharacter(String baseName) {
+	private static String lowerFirstCharacter(String baseName) {
 		return baseName.toLowerCase().substring(0, 1) + baseName.substring(1, baseName.length());
 	}
 }