Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squid:S2162, squid:S1488 - equals methods should be symmetric and wor… #1046

Merged
merged 1 commit into from
Feb 4, 2016
Merged

squid:S2162, squid:S1488 - equals methods should be symmetric and wor… #1046

merged 1 commit into from
Feb 4, 2016

Conversation

m-ezzat
Copy link

@m-ezzat m-ezzat commented Feb 3, 2016

This pull request is focused on resolving occurrences of Sonar rules squid:S2162, squid:S1488 - equals methods should be symmetric and work for subclasses, Local Variables should not be declared and then immediately returned or thrown

You can find more information about the issue here:
https://dev.eclipse.org/sonar/coding_rules#q=squid:S2162
https://dev.eclipse.org/sonar/coding_rules#q=squid:S1488

Please let me know if you have any questions.

M-Ezzat

…k for subclasses, Local Variables should not be declared and then immediately returned or thrown
@Turini
Copy link
Member

Turini commented Feb 4, 2016

great! thanks @m-ezzat

Turini added a commit that referenced this pull request Feb 4, 2016
…d-be-symmetric-and-work-for-subclasses,-Local-Variables-should-not-be-declared-and-then-immediately-returned-or-thrown-fix-1

squid:S2162, squid:S1488 - equals methods should be symmetric and wor…
@Turini Turini merged commit 9c37e62 into caelum:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants