Code Quality Improvement - Exception handlers should preserve the original exception #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Rodrigo, I see the issue comes from case when br.com.caelum.vraptor.core.DefaultConverters#classes doesn't clean properly between sequential tests. So CDIBasedContainerTest.setup() method may occasional fails. Cheers |
| errors.add(ex.getValidationMessage().withCategory(target.getName())); | ||
| } catch (IllegalStateException e) { | ||
| logger.warn("An error occured while getting validation message", e); |
There was a problem hiding this comment.
i'd use logger#debug in both cases... what do you think?
There was a problem hiding this comment.
Agree, I'll change it to logger.debug
|
Amazing PR, @civanyp! Thank you for doing this |
…ginal exception Update Code Quality Improvement - Update with logger.debug
|
Updated logger.debug! |
Turini
added a commit
that referenced
this pull request
Dec 4, 2015
…hould-preserve-the-original-exception-fix-1 Code Quality Improvement - Exception handlers should preserve the original exception
|
amazing! thank you again, @civanyp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S1166 - “Exception handlers should preserve the original exception”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1166
Please let me know if you have any questions.
Christian