Code Quality Improvement - Exception handlers should preserve the ori…

…ginal exception

Update

Code Quality Improvement -  Update with logger.debug

vraptor-core/src/main/java/br/com/caelum/vraptor/environment/DefaultEnvironment.java

@@ -101,7 +101,7 @@ private void loadAndPut(String environment) {
 			properties.load(resource);
 			LOG.debug("File {}.properties loaded", environment);
 		} catch (NullPointerException | IOException whenNotFound) {
-			LOG.warn("Could not find the file " + environment + ".properties to load.");
+			LOG.warn("Could not find the file " + environment + ".properties to load.", whenNotFound);
 		}
 	}
 

vraptor-core/src/main/java/br/com/caelum/vraptor/http/iogi/VRaptorInstantiator.java

@@ -21,6 +21,9 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import javax.annotation.PostConstruct;
 import javax.enterprise.context.RequestScoped;
 import javax.inject.Inject;
@@ -50,6 +53,8 @@
 @RequestScoped
 public class VRaptorInstantiator implements InstantiatorWithErrors, Instantiator<Object> {
 
+	private static final Logger logger = LoggerFactory.getLogger(VRaptorInstantiator.class);
+
 	private MultiInstantiator multiInstantiator;
 	private List<Message> errors;
 
@@ -164,8 +169,10 @@ public Object instantiate(Target<?> target, Parameters parameters) {
 
 				return converterForTarget(target).convert(parameter.getValue(), target.getClassType());
 			} catch (ConversionException ex) {
+				logger.debug("Could not convert target", ex);
 				errors.add(ex.getValidationMessage().withCategory(target.getName()));
 			} catch (IllegalStateException e) {
+				logger.debug("An error occured while getting validation message", e);
 				return setPropertiesAfterConversions(target, parameters);
 			}
 			return null;

vraptor-core/src/main/java/br/com/caelum/vraptor/http/route/DefaultParametersControl.java

@@ -50,7 +50,7 @@
 @Vetoed
 public class DefaultParametersControl implements ParametersControl {
 
-	private final Logger logger = LoggerFactory.getLogger(DefaultParametersControl.class);
+	private static final Logger logger = LoggerFactory.getLogger(DefaultParametersControl.class);
 	private final List<String> parameters = new ArrayList<>();
 	private final Pattern pattern;
 	private final String originalPattern;

vraptor-core/src/main/java/br/com/caelum/vraptor/interceptor/FlashInterceptor.java

@@ -90,7 +90,7 @@ public void beforeRedirect() {
 						session.setAttribute(FLASH_INCLUDED_PARAMETERS, new HashMap<>(included));
 					} catch (IllegalStateException e) {
 						LOGGER.warn("HTTP Session was invalidated. It is not possible to include " +
-								"Result parameters on Flash Scope");
+								"Result parameters on Flash Scope", e);
 					}
 				}
 			}

vraptor-core/src/main/java/br/com/caelum/vraptor/observer/RequestHandlerObserver.java

@@ -93,12 +93,13 @@ public void handle(@Observes VRaptorRequestStarted event) {
 			interceptorStack.start();
 			endRequestEvent.fire(new RequestSucceded(request, response));
 		} catch (ControllerNotFoundException e) {
+			LOGGER.debug("Could not found controller method", e);
 			controllerNotFoundHandler.couldntFind(event.getChain(), request, response);
 		} catch (MethodNotAllowedException e) {
-			LOGGER.debug(e.getMessage(), e);
+			LOGGER.debug("Method is not allowed", e);
 			methodNotAllowedHandler.deny(request, response, e.getAllowedMethods());
 		} catch (InvalidInputException e) {
-			LOGGER.debug(e.getMessage(), e);
+			LOGGER.debug("Invalid input", e);
 			invalidInputHandler.deny(e);
 		}
 	}

vraptor-core/src/main/java/br/com/caelum/vraptor/observer/upload/CommonsUploadMultipartObserver.java

@@ -151,7 +151,7 @@ protected String getValue(FileItem item, ServletRequest request) {
 			try {
 				return item.getString(encoding);
 			} catch (UnsupportedEncodingException e) {
-				logger.warn("Request have an invalid encoding. Ignoring it");
+				logger.debug("Request has an invalid encoding. Ignoring it", e);
 			}
 		}
 		return item.getString();

vraptor-core/src/main/java/br/com/caelum/vraptor/util/SafeResourceBundle.java

@@ -23,6 +23,9 @@
 
 import javax.enterprise.inject.Vetoed;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * A Resource bundle that doesn't throw exception when there is no resource of given key.
  * It only returns ??? + key + ??? when the key doesn't exist.
@@ -33,6 +36,7 @@
 @Vetoed
 public class SafeResourceBundle extends ResourceBundle {
 
+	private static final Logger logger = LoggerFactory.getLogger(SafeResourceBundle.class);
 	private final ResourceBundle delegate;
 	private final boolean isDefault;
 
@@ -59,6 +63,7 @@ protected Object handleGetObject(String key) {
 		try {
 			return delegate.getString(key);
 		} catch (MissingResourceException e) {
+			logger.warn("Resource missed while calling delegate", e);
 			return "???" + key + "???";
 		}
 	}

vraptor-core/src/main/java/br/com/caelum/vraptor/view/DefaultRefererResult.java

@@ -39,9 +39,14 @@
 import br.com.caelum.vraptor.http.route.Router;
 import br.com.caelum.vraptor.validator.Message;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 @RequestScoped
 public class DefaultRefererResult implements RefererResult {
-
+
+	private static final Logger logger = LoggerFactory.getLogger(DefaultRefererResult.class);
+
 	private final MutableRequest request;
 	private final Result result;
 	private final Router router;
@@ -73,6 +78,7 @@ public void forward() throws IllegalStateException {
 			ControllerMethod method = router.parse(referer, HttpMethod.GET, request);
 			executeMethod(method, result.use(logic()).forwardTo(method.getController().getType()));
 		} catch (ControllerNotFoundException | MethodNotAllowedException e) {
+			logger.warn("Could not find or doesn't allowed to get controller method", e);
 			result.use(page()).forwardTo(referer);
 		}
 	}
@@ -89,6 +95,7 @@ public void redirect() throws IllegalStateException {
 			ControllerMethod method = router.parse(referer, HttpMethod.GET, request);
 			executeMethod(method, result.use(logic()).redirectTo(method.getController().getType()));
 		} catch (ControllerNotFoundException | MethodNotAllowedException e) {
+			logger.warn("Could not find or doesn't allowed to get controller method", e);
 			result.use(page()).redirectTo(referer);
 		}
 	}

vraptor-core/src/main/java/br/com/caelum/vraptor/view/LinkToHandler.java

@@ -155,6 +155,7 @@ private Class<?> createLinkToInterface(final Class<?> controller, String interfa
 		try {
 			return Class.forName(interfaceName);
 		} catch (ClassNotFoundException e1) {
+			logger.warn("Could not find class", e1);
 			// ok, continue
 		}