Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firing CDI events on BeforeCommit, AfterCommit and AfterRollback. #30

Merged
merged 5 commits into from
Feb 25, 2015
Merged

Firing CDI events on BeforeCommit, AfterCommit and AfterRollback. #30

merged 5 commits into from
Feb 25, 2015

Conversation

rafaelGuerreiro
Copy link
Contributor

I also added one more test case, improved the setUp() on the tests and tested if the events were fired only when needed.

…pplication or other plugins can Observe these events and take some proper action.
@Turini
Copy link
Member

Turini commented Feb 24, 2015

Sounds nice to me, could you just add some docs about that on README?

@rafaelGuerreiro
Copy link
Contributor Author

Sure!!

@csokol
Copy link
Contributor

csokol commented Feb 24, 2015

I havent seen the code yet but it seems to be a great idea! I dont know why
but this reminds me the beforeredirectlistener from the core. I think we
should fire an event and deprecate the listener, what do you think?

Em 10:06 ter, 24/02/2015, Rodrigo Turini <notifications
notifications@github.com@ notifications@github.comgithub.com
notifications@github.com> escreveu:

@rafaelGuerreiro
Copy link
Contributor Author

@Turini, I've added the docs. Could you please validate it?

@lucascs
Copy link
Member

lucascs commented Feb 25, 2015

seems 👌 to me =)

@Turini
Copy link
Member

Turini commented Feb 25, 2015

thanks @rafaelGuerreiro, it looks great!

Turini added a commit that referenced this pull request Feb 25, 2015
Firing CDI events on BeforeCommit, AfterCommit and AfterRollback.
@Turini Turini merged commit bdbd63f into caelum:master Feb 25, 2015
@Turini
Copy link
Member

Turini commented Feb 25, 2015

I havent seen the code yet but it seems to be a great idea! I dont know
why but this reminds me the beforeredirectlistener from the core. I think
we should fire an event and deprecate the listener, what do you think?

@csokol, which listener are you talking about?

@csokol
Copy link
Contributor

csokol commented Feb 25, 2015

Sorry, I was on mobile. The right name is RedirectListener:
https://github.com/caelum/vraptor4/blob/master/vraptor-core/src/main/java/br/com/caelum/vraptor/http/VRaptorResponse.java#L52

I think we could deprecate that listener and that method to add the
listener and create a new event to fire before redirect.

On Wed Feb 25 2015 at 10:32:33 AM Rodrigo Turini notifications@github.com
wrote:

I havent seen the code yet but it seems to be a great idea! I dont know
why but this reminds me the beforeredirectlistener from the core. I think
we should fire an event and deprecate the listener, what do you think?

@csokol https://github.com/csokol, which listener are you talking
about?


Reply to this email directly or view it on GitHub
#30 (comment).

@Turini
Copy link
Member

Turini commented Feb 25, 2015

hum, now I see your point @csokol.
I've just opened an issue caelum/vraptor4#950 to track this

@rafaelGuerreiro rafaelGuerreiro deleted the work-issue7 branch February 25, 2015 14:30
@garcia-jj
Copy link
Member

@Turini can you release a new version for this plugin? Can help users with this feature.

@Turini
Copy link
Member

Turini commented Jul 30, 2015

Sure! I'll do it asap

@Turini
Copy link
Member

Turini commented Jul 30, 2015

I've just released vs 4.0.4:
https://github.com/caelum/vraptor-jpa/releases/tag/vraptor-jpa-4.0.4
it'l be available on maven's repo in a few hours. thks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants