Issue 6759: Regenerate common/blobstore/interface.go using mockgen #7267
+298
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansidev
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
|
|
||
| func TestRetryableClient_IsRetryableError(t *testing.T) { | ||
| mockClient := new(MockClient) | ||
| func (s *RetryableClientTestSuite) TestIsRetryableError() { |
There was a problem hiding this comment.
directionally, I think we'd like to move away from using the suite pattern towards plain table-tests and plain go, but in mixed files like this, it's certainly fine to move towards consistency.
There was a problem hiding this comment.
@davidporter-id-au moved away from using the suite pattern
davidporter-id-au
approved these changes
Sep 21, 2025
auto-merge was automatically disabled
September 21, 2025 23:27
Head branch was pushed to by a user without write access
ansidev
force-pushed
the
cadence-6759-common-blobstore
branch
2 times, most recently
from
c6a9faf to
a867f49
Compare
Signed-off-by: Le Minh Tri <ansidev@gmail.com>
Signed-off-by: Le Minh Tri <ansidev@gmail.com>
ansidev
force-pushed
the
cadence-6759-common-blobstore
branch
from
a867f49 to
5621486
Compare
davidporter-id-au
approved these changes
Sep 23, 2025
davidporter-id-au
merged commit 72d3984
into
cadence-workflow:master
39 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
common/blobstore/interface.gotocommon/blobstore/client.gocommon/blobstore/interface_mock.gotocommon/blobstore/client_mock.go.Why?
Fixes
https://github.com/cadence-workflow/cadence/issues/6759.How did you test it?
make testPotential risks
N/A
Release notes
N/A
Documentation Changes
N/A