Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] default domain registration using docker image #6619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samkitshah1262
Copy link
Contributor

Domain set up is now done through the docker image itself. No extra steps needed.

Towards #2343

Locally

Docker auto-setup image can be corrupted

Release notes

Documentation Changes

docker/start.sh Show resolved Hide resolved
@@ -75,6 +75,7 @@ COPY config/dynamicconfig /etc/cadence/config/dynamicconfig
COPY config/credentials /etc/cadence/config/credentials
COPY docker/config_template.yaml /etc/cadence/config
COPY docker/start-cadence.sh /start-cadence.sh
COPY docker/domain /domain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the changes for all target DBs. You can build the image locally and try the docker compose files under docker/ folder for cass/mysql/postgres. Let's update PR description to include all testing steps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After building the image locally, when I try to run it it gives the following logs -
2025-01-15 20:10:11 + CONFIG_TEMPLATE_PATH=/etc/cadence/config/config_template.yaml 2025-01-15 20:10:11 + dockerize -template /etc/cadence/config/config_template.yaml:/etc/cadence/config/docker.yaml 2025-01-15 20:10:11 + exec cadence-server --root /etc/cadence --env docker start --services=history,matching,frontend,worker 2025-01-15 20:10:11 2025/01/15 14:40:11 Loading config; env=docker,zone=,configDir=/etc/cadence/config 2025-01-15 20:10:11 2025/01/15 14:40:11 Loading configFiles=[/etc/cadence/config/docker.yaml] 2025-01-15 20:10:11 Error: Config file corrupted 2025-01-15 20:10:11 Error details: 2025-01-15 20:10:11 failed to validate config 2025-01-15 20:10:11 Persistence.DataStores[default](value).NoSQL.Hosts: zero value . I think I am missing a step in order to set up DB. I have installed schema and followed the steps in persistence.md . Could you please guide me on how to do it correctly. Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you building the image and what commands are you using it to run? If you share repo-able steps I can take a look

Copy link
Contributor Author

@samkitshah1262 samkitshah1262 Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker build -t cadence-server . - running this command in the root directory and running the image through docker desktop dashboard / docker run -d --name cadence-server -p 7933:7933 -p 7934:7934 -p 7935:7935 cadence-server , to run cassandra - docker-compose -f ./docker/dev/cassandra.yml up , make install-schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle follow up @taylanisikdemir , thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants