Add unit tests for History Iterator in Replayer #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Groxx,
abhishekj720,
natemort,
shijiesheng,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
commented
Nov 28, 2024
| } | ||
|
|
||
| @Test(expected = Error.class) | ||
| public void testGetHistoryFailure() |
There was a problem hiding this comment.
This is a spin lock :( retryOptions does not have a backoff coefficient. So it tries around 100 times in 4 seconds until it gives up. Our tests are rather slow, but I'm unsure how this should be resolved.
There was a problem hiding this comment.
I've switched to usage of validateBuildWithDefaults since I think it should be used instead of manual build()
natemort
approved these changes
Nov 28, 2024
...java/com/uber/cadence/internal/replay/ReplaceDeciderDecisionTaskWithHistoryIteratorTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added unit tests for DecisionTaskWithHistoryIterator inside Replayer.
I had to go with instanstiating private class, otherwise I need to build the whole history for replayer.
Why?
Improving code coverage.
How did you test it?
Potential risks
Release notes
Documentation Changes