Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete constants #317

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Oct 30, 2024

The validation path prefix is likely now zerosslHTTPValidationBasePath, and the API base here is broken ("https://" + somethingThatIncludesHTTPSAsWell).

The validation path prefix is likely now `zerosslHTTPValidationBasePath`, and the API base
here is broken (`"https://" + somethingThatIncludesHTTPSAsWell`).
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks! 🤦‍♂️

@mholt mholt merged commit 4c6eddc into caddyserver:master Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants