Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade only some otel deps #6676

Merged
merged 1 commit into from
Nov 5, 2024
Merged

go.mod: upgrade only some otel deps #6676

merged 1 commit into from
Nov 5, 2024

Conversation

mohammed90
Copy link
Member

otel libs are notorious for incompatibility within themselves, and it isn't clear how to sync them properly. To fix the latest failure, I upgraded only otelhttp and otlptracegrpc and had them work themselves out on upgrading the others. I saw the same breakage when upgraded only otelhttp, then upgrading otlptracegrpc fixed it. Fingers crossed 🤞🏼

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mohammed90 mohammed90 added the CI/CD 🔩 Automated tests, releases label Nov 4, 2024
@francislavoie francislavoie enabled auto-merge (squash) November 5, 2024 00:10
@francislavoie francislavoie merged commit 91e3413 into master Nov 5, 2024
32 of 33 checks passed
@francislavoie francislavoie deleted the fix-otel-issue branch November 5, 2024 00:10
@francislavoie
Copy link
Member

We'll see 🤷‍♂️

@mholt
Copy link
Member

mholt commented Nov 5, 2024

Thanks for this!

@mholt mholt added this to the v2.9.0-beta.3 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants