Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Add placeholder for networkAddr in active health check headers #6450

Merged

Conversation

dylanschultzie
Copy link
Contributor

Follows: #6440

Previously hostAddr would duplicate the Host header. This now appropriately passes the full original upstream:

5.0.0.33 - - [09/Jul/2024 15:35:04] "GET /health HTTP/1.1" 200 -
+Host: 5.0.0.33:53336
User-Agent: Go-http-client/1.1
+Full-Upstream: 5.0.0.33:8545
Accept-Encoding: gzip

Resolves forum post: https://caddy.community/t/can-you-pass-in-the-full-upstream-to-an-active-health-check/24718

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Jul 9, 2024
@francislavoie francislavoie enabled auto-merge (squash) July 9, 2024 18:03
@francislavoie francislavoie merged commit 4943a4f into caddyserver:master Jul 9, 2024
23 checks passed
@dylanschultzie dylanschultzie deleted the schultzie/target_dial branch July 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants