caddyhttp: Accept XFF header values with ports, when parsing client IP #6183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
force-pushed
the
client-ip-with-port
branch
from
33d36e1 to
599d2a8
Compare
mholt
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://caddy.community/t/trusted-proxies-in-openshift/23205
As it turns out, some proxies like OpenShift (Red Hat Kubernetes platform) keep the port in the X-Forwarded-For header (or whatever configured client IP header). That's weird, but apparently not unheard of.
We weren't splitting up the value, so when we passed it to
netip.ParseAddrit would fail, so theclient_ipin logs didn't get populated. This fixes that, and add some clarifying comments in surrounding code.