Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix the output of the Usage section #6138

Merged
merged 1 commit into from
Mar 1, 2024
Merged

cmd: fix the output of the Usage section #6138

merged 1 commit into from
Mar 1, 2024

Conversation

mohammed90
Copy link
Member

@mohammed90 mohammed90 commented Mar 1, 2024

Before:

Usage:
  caddy file-server [flags]
  caddy file-server [command]

After:

Usage:
  caddy file-server [--domain <example.com>] [--root <path>] [--listen <addr>] [--browse] [--reveal-symlinks] [--access-log] [--precompressed] [flags]
  caddy file-server [command]

CC/ @SerheyDolgushev

@mohammed90 mohammed90 marked this pull request as ready for review March 1, 2024 15:29
@mohammed90 mohammed90 marked this pull request as draft March 1, 2024 15:32
@francislavoie francislavoie added the bug 🐞 Something isn't working label Mar 1, 2024
@mohammed90 mohammed90 marked this pull request as ready for review March 1, 2024 15:32
@francislavoie francislavoie added this to the v2.8.0 milestone Mar 1, 2024
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me 👍

@mohammed90 mohammed90 merged commit de4959f into master Mar 1, 2024
25 checks passed
@mohammed90 mohammed90 deleted the fix-usage branch March 1, 2024 16:00
armadi1809 pushed a commit to armadi1809/caddy that referenced this pull request Mar 4, 2024
mholt added a commit that referenced this pull request Mar 5, 2024
…luggable (#6050)

* Made trusted leaf certificates pluggable into the tls.client_auth.leaf
module

* Added leaf loaders modules: file, folder, pem aand storage

* Cleaned implementation of leaf cert loader modules

* Added tests for leaf certs file and folder loaders

* cmd: fix the output of the `Usage` section (#6138)

* core: OnExit hooks (#6128)

* core: OnExit callbacks

* core: Process-global OnExit callbacks

* ci: bump golangci/golangci-lint-action from 3 to 4 (#6141)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added more leaf certificate loaders tests and cleaned up code

* Modified leaf cert loaders json field names and cleaned up storage loader comment

* Update modules/caddytls/leaffileloader.go

* Update LeafStorageLoader certificates field name

* Upgraded  protobuf version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Mohammed Al Sahaf <msaa1990@gmail.com>
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants