caddyauth: Rename basicauth to basic_auth
#6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Feb 12, 2024
This allows `basic_auth` to work as well in the Caddyfile, and emits a deprecation warning when `basicauth` is used.
francislavoie
force-pushed
the
rename-basicauth
branch
from
ba290d3 to
8661cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
basic_authto work as well in the Caddyfile, and emits a deprecation warning whenbasicauthis used.This was essentially a mistake in v2.0, we made the decision to use underscores for directives that are multiple words like
file_serveretc, but we leftbasicauth. Since then, we've addedforward_auth, sobasicauthfeels incongruent with that.I think now's as good a time as any to realign this.