Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacer: change timezone to UTC for "time.now.http" placeholders #5774

Merged
merged 2 commits into from
Aug 22, 2023
Merged

replacer: change timezone to UTC for "time.now.http" placeholders #5774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0af4123
replacer: change timezone to UTC for "time.now.http" placeholders
WeidiDeng Aug 22, 2023
b69472c
add comments
WeidiDeng Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion replacer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,10 @@ func globalDefaultReplacements(key string) (any, bool) {
case "time.now":
return nowFunc(), true
case "time.now.http":
return nowFunc().Format(http.TimeFormat), true
// According to the comment for http.TimeFormat, the timezone must be in UTC
// to generate the correct format.
// https://github.com/caddyserver/caddy/issues/5773
return nowFunc().UTC().Format(http.TimeFormat), true
case "time.now.common_log":
return nowFunc().Format("02/Jan/2006:15:04:05 -0700"), true
case "time.now.year":
Expand Down