Fix hanging caused by Transfer-Encoding: chunked #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes caddyserver#5236 * enable request body buffering in reverse proxy when the request header has Transfer-Encoding: chunked
francislavoie
approved these changes
Jan 8, 2023
There was a problem hiding this comment.
LGTM, but I'd like @mholt to review as well just in case he can think of some edgecase/oversight to this.
mholt
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
This looks nice and clean. Thank you for the patch! I am so glad you contributed this 😃
Edit: As for edge cases, is there one? No idea. Probably. But I think the current logic is still an improvement. We can try it and see how it fares in the wild. If people experience issues with it we'll let you know! 👍
Narrator: There were definitely edge cases. See #5366.
mholt
added a commit
that referenced
this pull request
Feb 10, 2023
mholt
added a commit
that referenced
this pull request
Feb 12, 2023
* reverseproxy: Don't buffer chunked requests (fix #5366) Mostly reverts 845bc4d (#5289) Adds warning for unsafe config. Deprecates unsafe properties in favor of simpler, safer designed ones. * Update modules/caddyhttp/reverseproxy/caddyfile.go Co-authored-by: Y.Horie <u5.horie@gmail.com> * Update modules/caddyhttp/reverseproxy/reverseproxy.go Co-authored-by: Y.Horie <u5.horie@gmail.com> * Update modules/caddyhttp/reverseproxy/reverseproxy.go Co-authored-by: Y.Horie <u5.horie@gmail.com> * Remove unused code --------- Co-authored-by: Y.Horie <u5.horie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the request header has Transfer-Encoding: chunked