Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add pushing to cloudsmith #3941

Merged
merged 5 commits into from
Dec 30, 2020
Merged

Conversation

francislavoie
Copy link
Member

See caddyserver/dist#49

Still needs CLOUDSMITH_API_KEY to be added to the repo/org @mholt, I don't remember if you've done it already? Please let me know 😄 leaving as draft until that's confirmed and my TODO is fixed.

Also adds a condition to skip the caddy_<version>_linux_armv7.deb because Cloudsmith would complain and Gemfury would have it override the armv6 one, because apparently they're both armhf. But maybe we should skip the armv6 one instead of armv7? I don't know. I assume the armv6 one would be more compatible 🤷‍♂️ but I don't know anything about ARM arch differences.

@mholt
Copy link
Member

mholt commented Dec 29, 2020

@francislavoie Aye, the CLOUDSMITH_API_KEY secret was created on Oct 31.

As for ARM version, I suspect v7 because most people are probably running newer hardware, but I'm soliciting feedback, since I'm not sure how that works either: https://twitter.com/mholt6/status/1343984040131477504

@francislavoie francislavoie marked this pull request as ready for review December 29, 2020 20:02
@francislavoie
Copy link
Member Author

francislavoie commented Dec 29, 2020

Just waiting for @mohammed90's review, then I think this is ready to go.

Might want to configure the GPG key in cloudsmith before we do tag the test release though.

mholt
mholt previously approved these changes Dec 30, 2020
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for helping with this, Francis. Excited to try it out.

@mholt mholt merged commit 79f3af9 into caddyserver:master Dec 30, 2020
@francislavoie francislavoie deleted the cloudsmith branch December 30, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants