-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add pushing to cloudsmith #3941
Conversation
06016bb
to
746a021
Compare
@francislavoie Aye, the CLOUDSMITH_API_KEY secret was created on Oct 31. As for ARM version, I suspect v7 because most people are probably running newer hardware, but I'm soliciting feedback, since I'm not sure how that works either: https://twitter.com/mholt6/status/1343984040131477504 |
Just waiting for @mohammed90's review, then I think this is ready to go. Might want to configure the GPG key in cloudsmith before we do tag the test release though. |
46ebe3d
to
3821319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for helping with this, Francis. Excited to try it out.
See caddyserver/dist#49
Still needs
CLOUDSMITH_API_KEY
to be added to the repo/org @mholt, I don't remember if you've done it already? Please let me know 😄 leaving as draft until that's confirmed and my TODO is fixed.Also adds a condition to skip the
caddy_<version>_linux_armv7.deb
because Cloudsmith would complain and Gemfury would have it override thearmv6
one, because apparently they're botharmhf
. But maybe we should skip thearmv6
one instead ofarmv7
? I don't know. I assume thearmv6
one would be more compatible 🤷♂️ but I don't know anything about ARM arch differences.