Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpcaddyfile: Add certificate_pem placeholder short, add to godoc #3846

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

gdhameeja
Copy link
Contributor

Added godoc comments and CaddyFile shortcut for certificate_pem
placeholder

Added godoc comments and CaddyFile shortcut for `certificate_pem`
placeholder
@francislavoie francislavoie added this to the v2.3.0 milestone Nov 4, 2020
francislavoie
francislavoie previously approved these changes Nov 4, 2020
@francislavoie
Copy link
Member

This is a follow-up to #3662 👍

@francislavoie francislavoie changed the title doc: godoc comments,CaddyFile shortcut - certificate_pem httpcaddyfile: Add certificate_pem placeholder short, add to godoc Nov 4, 2020
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks so much! Just a typo :)

modules/caddyhttp/app.go Outdated Show resolved Hide resolved
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
@gdhameeja
Copy link
Contributor Author

Great, thanks so much! Just a typo :)

fixed.

@francislavoie francislavoie merged commit 7c28ecb into caddyserver:master Nov 4, 2020
@gdhameeja gdhameeja deleted the doc-3585 branch November 5, 2020 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants