Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Fix panic when headers aren't written #3737

Merged

Conversation

hairyhenderson
Copy link
Collaborator

Fixes #3734

I hadn't accounted for the emptyHandler!

Signed-off-by: Dave Henderson dhenderson@gmail.com

Signed-off-by: Dave Henderson <dhenderson@gmail.com>
@hairyhenderson hairyhenderson added the bug 🐞 Something isn't working label Sep 19, 2020
@hairyhenderson hairyhenderson self-assigned this Sep 19, 2020
@francislavoie francislavoie added this to the v2.2.0 milestone Sep 19, 2020
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to fix this!

@mholt mholt merged commit b1d456d into caddyserver:master Sep 21, 2020
@hairyhenderson hairyhenderson deleted the metrics-fix-panic-when-code-missing branch September 21, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caddyfile config mistake causes panic
3 participants