-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[file-server] Add "from" parameter to browse complementary to "limit" #3542
Conversation
I think |
Thanks for the PR! I'll try to give it a pass soon. |
that's reasonable too, should I change it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! Except changing to offset
sounds like a good idea. Although "from" isn't bad, "offset" makes a little more sense I think.
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
change from -> offset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
A simple update to the browse functionality within the file-server
Use case -> To efficiently browse folders with many... many... files
Usage
caddy file-server --listen 8000 --browse
http://localhost:8000/browse
Shows all files
http://localhost:8000/browse?limit=10
Shows only files 10 files starting from 0
http://localhost:8000/browse?limit=10&from=5
Shows only files 10 files starting from 5