httpcaddyfile: Make global options pluggable #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I'm surprised this works 🤔 Will look at this more after 2.0! (Edit: Thanks for the test case too.) |
francislavoie
force-pushed
the
pluggable-global-opts
branch
from
313bd56 to
048c275
Compare
mholt
reviewed
Apr 27, 2020
francislavoie
force-pushed
the
pluggable-global-opts
branch
from
ab383be to
8f769de
Compare
|
I'd like if we could merge this one earlier rather than later, useful for plugin authors and it would avoid merge conflicts to merge earlier if anything else needs to add/change global options |
mholt
previously approved these changes
May 11, 2020
Co-Authored-By: Dave Henderson <dhenderson@gmail.com>
francislavoie
force-pushed
the
pluggable-global-opts
branch
from
8f769de to
514be72
Compare
|
Fixed 👍 |
mholt
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor to make global options be registerable like Caddyfile directives.
It makes it possible for plugins/modules to add their own global options if their configuration doesn't make sense to be inside a server block.
The only functional change here should be the error messages.