-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pki: Embedded ACME server #3198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/caddypki/ca.go
# Conflicts: # modules/caddyhttp/reverseproxy/httptransport.go # modules/caddyhttp/reverseproxy/ntlm.go
# Conflicts: # go.mod # go.sum
mholt
added a commit
that referenced
this pull request
Apr 9, 2020
We'll need that context in v2.1 when the transport can manage its own client certificates; see #3198
mholt
removed
in progress 🏃♂️
Being actively worked on
do not merge ⛔
Not ready yet!
labels
Apr 17, 2020
# Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an embedded ACME server, powered by Smallstep libraries.
See #3021
It's really cool! You can use it simply by giving your own ACME directory endpoint in your other Caddy configs.
🚫 Not ready to merge.✅ Ready to merge after 2.0Still some cleanup to do, and some more features to come as well!
Below is a config that demonstrates this feature. To use it, simply add
smallstep.rocks
to your hosts file so that it points to 127.0.0.1.When you start Caddy, you should see that it will try to obtain a certificate for
smallstep.rocks
from the ACME CA athttps://localhost/acme/local/directory
.My logs:
You'll notice that the ACME server is in fact just an HTTP handler module, which is pretty neat.
The above config also uses all default settings, but some things can be customized.
/cc @mmalone @maraino @dopey - at some point, it would be good to do a review together!
Update/bonus: TLS client auth certs can now be automated as well!