ci: update the linter action version (#6575)

* ci: update the linter action version Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com> * exclude rule `G115`; disable deprecated linter Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com> --------- Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
caddyserver · Sep 16, 2024 · 6ab9fb6 · 6ab9fb6
1 parent f4bf4e0
commit 6ab9fb6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -49,7 +49,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.60
+          version: latest
 
           # Windows times out frequently after about 5m50s if we don't set a longer timeout.
           args: --timeout 10m

diff --git a/.golangci.yml b/.golangci.yml
@@ -35,7 +35,6 @@ linters:
     - errcheck
     - errname
     - exhaustive
-    - exportloopref
     - gci
     - gofmt
     - goimports
@@ -145,6 +144,9 @@ output:
 
 issues:
   exclude-rules:
+    - text: 'G115' # TODO: Either we should fix the issues or nuke the linter if it's bad
+      linters:
+        - gosec
     # we aren't calling unknown URL
     - text: 'G107' # G107: Url provided to HTTP request as taint input
       linters:

diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go
@@ -817,7 +817,6 @@ func (s *Server) logRequest(
 		}
 
 		if fields == nil {
-
 			userID, _ := repl.GetString("http.auth.user.id")
 
 			reqBodyLength := 0
-Original file line number
+Diff line change
@@ Expand Up / @@ -817,7 +817,6 @@ func (s *Server) logRequest( @@
     		}
     		if fields == nil {
     			userID, _ := repl.GetString("http.auth.user.id")
     			reqBodyLength := 0
@@ Expand Down @@