Pull in latest finance info automatically #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Let's hold off on merging this, to avoid conflicts with the other in-flight PRs, but please review if you have a chance. |
adborden
changed the title
Closed
Committees and referendums have no finance data in them, they exist solely in collections.
For example, run arbitrary gulp task with:
$ npm run gulp -- pull:candidates
Remove referendum opposing/supporting from collections, they only exist as finance data under _data.
We no longer include the finance data in the repo. Developers should run the npm task to get the latest finance data.
Ignores the finance data in version control.
Trick liquid into using a default empty array.
Specify vendor path for bundler so we can cache that directory.
adborden
force-pushed
the
feature/auto-finance
branch
from
79b10df to
08476a5
Compare
adborden
changed the title
|
@tdooner this is ready to review! Hold off on merging—I just want to post in slack when merged so that folks know they have to run a few steps to get a working setup. That is... |
* upstream/master: Update candidate.html updated localhost url to reflect proper root being served Update _candidate.scss Update _candidate.scss Second attempt at ticket 164. Added incumbent status, committee name, and expenditure ceiling Styling for referendum contributions by type Add contributions by type to referendum page Remove referendum supporting/opposing pages ballot nav added to referendum pages CI should build production
|
This looks great, I'm excited for this. I resolved a couple merge conflicts and I think we should be good to go. Let's make sure to communicate the changes on wednesday. Deferring to you to hit the merge button, @adborden ! |
tdooner
approved these changes
May 6, 2018
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, this worked out really well, I think. Resolves #66, resolves #67.
I moved the finance info to
_data, so human edits to the collection files will persist when you import finance data from disclosure-backend-static. It does have the side-effect of now the ballot data has to be updated manually, but I think that is the eventual goal (since we want to get rid of the spreadsheet).This allows us to update the finance data automatically, so I created a scheduled task in CI to do this. Pushing to master will still trigger a deploy, but twice daily CI will pull in disclosure-backend-static and deploy the latest finance data.
The finance data is git-ignored, so developers now are required to clone disclosure-backed-static and install the Node.js dependencies in order to get finance data for local development.
This gets us pretty close to merging this repo with disclosure-backend-static, at least superficially. Not sure what the long term plan is for the backend build files. Right now, you don't need to install the ruby dependencies to get the finance data for the front end.