Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0: Rewrite in Python #745

Closed
wants to merge 83 commits into from
Closed

1.0: Rewrite in Python #745

wants to merge 83 commits into from

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Jul 21, 2023

devenv started as a bash wrapped in Nix to explore the design space.

As a result, there were many subtle bugs and lack of features that were hard to implement.

Previous devenv was 240M in closure and now it's down to 126M.

TODO

  • Bump to Nix 2.17
  • Investigate a bug when .nix files are caches (eval-cache?)
  • Python native libraries support is broken
  • macOS intel crashes sometimes
  • Fix devenv gc
  • Fix flake.nix support
  • Run devenv ci things in favor of devenv test.

Fixes

Fixes #744
Fixes #693
Fixes #658
Fixes #244
Fixes #436
Fixes #629
Fixes #731
Fixes #83
Fixes #80
Fixes #749
Fixes #507
Fixes #258
Fixes #486
Fixes #745
Fixes #599
Fixes #607

Try it out 🚀

Add devenv.yaml:

inputs:
  devenv:
     url: github:cachix/devenv/python-rewrite 

Plain Nix

cachix use devenv
nix-env -if https://install.devenv.sh/python-rewrite

Flakes

nix profile install --accept-flake-config tarball+https://install.devenv.sh/python-rewrite

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ee4450
Status: ✅  Deploy successful!
Preview URL: https://2ea85a40.devenv.pages.dev
Branch Preview URL: https://python-rewrite.devenv.pages.dev

View logs

@domenkozar domenkozar marked this pull request as draft July 21, 2023 16:09
@domenkozar domenkozar force-pushed the python-rewrite branch 8 times, most recently from b2b1576 to acb5e15 Compare July 22, 2023 10:45
@domenkozar
Copy link
Member Author

I noticed that --debugger doesn't really work as we need to properly attach stdin.

@domenkozar domenkozar force-pushed the python-rewrite branch 12 times, most recently from 009ab8f to 1fe46f8 Compare July 22, 2023 17:57
src/devenv/cli.py Outdated Show resolved Hide resolved
@domenkozar
Copy link
Member Author

It seems like we're hitting something similar to nix-community/poetry2nix#596, investigating.

@domenkozar domenkozar force-pushed the python-rewrite branch 2 times, most recently from 941b1bd to 25e6115 Compare July 23, 2023 12:14
@Nebucatnetzer
Copy link
Contributor

Nebucatnetzer commented Mar 5, 2024

I tested it against our current setup and haven't found any problems so far.
locale -a shows now not just the system locales which is nice.

Edit: devenv up still triggers evaluation in Flake, I reckon that's more of a problem with Flakes than with devenv?

@domenkozar
Copy link
Member Author

Continuation of this work is ready for another round of testing: #1005

@domenkozar domenkozar closed this Mar 11, 2024
cameronraysmith added a commit to pinellolab/DNA-Diffusion that referenced this pull request Jul 30, 2024
... pending resolution of
cachix/devenv#745 (comment)
Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
cameronraysmith added a commit to pinellolab/DNA-Diffusion that referenced this pull request Jul 30, 2024
... pending resolution of
cachix/devenv#745 (comment)
Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
cameronraysmith added a commit to pinellolab/DNA-Diffusion that referenced this pull request Jul 30, 2024
... pending resolution of
cachix/devenv#745 (comment)
Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet