Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): set $CARGO_INSTALL_ROOT and $PATH used in cargo install #721

Merged
merged 5 commits into from
Aug 27, 2023

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Jul 11, 2023

Motivation

When you have multiple devenv managed Rust projects, you want them to use their own $CARGO_INSTALL_ROOT, otherwise cargo install will overwrite executables that belong to other projects.

See https://doc.rust-lang.org/cargo/commands/cargo-install.html

@Atry Atry requested a review from shyim July 13, 2023 14:35
@Atry
Copy link
Contributor Author

Atry commented Jul 15, 2023

Could you review this PR again, please? @shyim

@Atry Atry requested a review from shyim July 20, 2023 17:17
@Atry Atry changed the title Set $CARGO_INSTALL_ROOT and $PATH used in cargo install feat(rust): set $CARGO_INSTALL_ROOT and $PATH used in cargo install Jul 20, 2023
@Atry
Copy link
Contributor Author

Atry commented Jul 22, 2023

@domenkozar Do you want to review and merge this PR?

@Atry Atry requested a review from domenkozar August 5, 2023 21:22
@domenkozar
Copy link
Member

@Atry I tried to resolve the merge conflict, but it created an issue with formatters. Could you run pre-commit run -a and commit?

@Atry
Copy link
Contributor Author

Atry commented Aug 27, 2023

Formatted

@domenkozar domenkozar merged commit 68ea687 into cachix:main Aug 27, 2023
@Atry Atry deleted the patch-4 branch August 28, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants