-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added kafka service #1565
base: main
Are you sure you want to change the base?
Conversation
Update: I have added initial connectors to kafka connect, but they don't seem to persist when i restart kafka connect, not sure why. |
Okay, I figured it out, you could just pass the connectors to the start command |
Take a look at https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/misc/apache-kafka.nix. You should be able to reuse large parts of this, particularly the config/settings handling, and ideally keep a similar interface. |
Also added defaults to run in kraft mode
Hey @sandydoo thanks for the feedback! I probably also need to create settings for kafka connect. I would also like to have some kind of readiness probe for kafka. TODO:
|
That's the right approach. @Alexnortung, is there a basic test we could add for this to make sure it launches? I'm not familiar with Kafka, but maybe a ping/healthcheck/queue-unqueue type of thing. See the |
Hi @sandydoo I have Added settings to kafka connect and added a test for kafka. |
Here is a rough implementation of a kafka service for devenv.
I think there are definetely place for configuration options. but I am not sure how we can implement this properly. So feedback would be appreciated :)
closes #1563