introduce languages.python.finalPackage #1542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow overriding the wrapper-python package by introducing the languages.python.finalPackage option, which replaces the let-variable.
The variable 'package' currently referred to finalPackage. This was a bit confusing. Instead, this introduces 'interpreter' and 'sitePackages', which refer to those from finalPackage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it isn't possible to use
languages.pythonwithout theLD_LIBRARY_PATHwrapper. Since this wrapper resulted into some unwanted side-effects I'd like to be able to override the wrapper as well.languages.python.packageis the unwrapped package andlanguages.python.finalPackagewrapslanguages.python.package, which is in turn used like it was previously.Since the
package = cfg.finalPackage;was a bit confusing, I opted to replace this withinherit (cfg.finalPackage) interpreter sitePackages;.