fix: output non-zero code when devenv test
fails
#1510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we don't exit with code
0
ifdevenv test
fails.This requires both a module and a CLI update. On older versions of devenv, the updated tasks runner will cut of a bit of output at the end ("Tests failed :("), as it bails out of the
nix develop
command early.I would've preferred something like
cmd.run().await?.bail_on_error()
, where we can make the decision to bail on each invocation, but that's a bit too invasive at this time.Reported on Discord.