feat: add environment variables for process-compose #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These environment variables enable commands like `process-compose process list`
|
Can you make a PR against #1161 since we'll merge that soon? Thanks! |
|
Needs a rebase |
|
Rebased |
sandydoo
approved these changes
Oct 13, 2024
There was a problem hiding this comment.
I've pushed the following fixes:
- Filtered out
PC_CONFIG_FILESfrom the final config to avoid infinite recursion. - Updated things to use the new renamed process compose options.
I've also dropped PC_DISABLE_TUI. I'm not quite sure why we'd want to set this by default. End users may want to set this in their own config to temporarily override tui.enable. And we also have that devenv-specific PC_TUI_ENABLED var that we need to support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These environment variables enable
process-composecommands likeprocess-compose process list