c: fix an issue where the wrong c/cpp compiler could be set up #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already add `stdenv`, which contains all the compilers and sets up the `CC` and `CXX` env variables for each platform. Adding `clang` or `gcc` on top can result in the wrong compilers being set up for the current platform, e.g. gcc on macOS. We saw this happen when building native extensions in ruby.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already add
stdenv, which contains all the compilers and sets up theCCandCXXenv variables for each platform. Addingclangorgccon top can result in the wrong compilers being set up for the current platform, e.g. gcc on macOS. We saw this happen when building native extensions in ruby.I imagine this broke once we switched back to
nix develop.Also, this might fix the macos ruby tests 👀
Fixes #966.
Fixes #965.