Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: don't let hook packages override language ones #1131

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

sandydoo
Copy link
Member

The packages defined by languages should take priority over the ones loaded by pre-commit. This pushes any enabledPackages to the end of PATH.

Language modules should still manually override the pre-commit packages to keep things in sync.

Fixes #1103.

The packages defined by languages should take priority over the ones
loaded by pre-commit. This pushes any `enabledPackages` to the end of
PATH.

Language modules should still manually override the pre-commit packages
to keep things in sync.

Fixes #1103.
Copy link

cloudflare-workers-and-pages bot commented Apr 15, 2024

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 509b72e
Status: ✅  Deploy successful!
Preview URL: https://b9cd100e.devenv.pages.dev
Branch Preview URL: https://fix-1103.devenv.pages.dev

View logs

@domenkozar domenkozar merged commit 9b6673e into main Apr 16, 2024
234 of 256 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit hook packages can conflict/override language packages
2 participants