modules: exclude more environment variables #1069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some more environment variables and update corresponding option description.
domenkozar
reviewed
Apr 1, 2024
| "buildInputs" | ||
| "buildPhase" | ||
| "builder" | ||
| "cmakeFlags" | ||
| "configureFlags" |
There was a problem hiding this comment.
I'm not sure we should exclude cmakeFlags, configureFlags and mesonFlags because someone might want to add a library that provides these via hooks to packages to build their C program.
There was a problem hiding this comment.
I thought cmakeFlags + other flags excluded in this PR are in the same category as other already excluded variables.
someone might want to add a library that provides these via hooks to packages to build their C program.
Is this going to work when for example buildInputs is removed from shell (buildInputs is already in unsetEnvVars list ) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some more environment variables and update corresponding option
description.