Fixes to pass rubyonrails test #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails listens on port 3000 by default.
The test outputted errors regarding upon running `rails new` that `.gitignore` already exists. For the test it doesn't really matter to overwrite these files, so I added `--force`.
Currently postgres fails to create a database because my username contains a `.`. Wrapping the database name in `"` will resolve the problem. I've rewritten the line to use HEREDOC so that we do not have to mess with escaping (from Nix) within escaping (from Bash) within escaping (from psql). Now it only escapes using Nix and psql.
Currently whenever the examples are changed, devenv will need to be rebuild. This isn't needed, because the package isn't relying on the examples explicity. Using `builtins.path` was just too much of a hassle (paths are absolute, directory path needs to be match along with sub-files/directories). Regex seemed easier. Regex in Nix uses extended Posix, which is again a bit funky, but maybe less so than doing matching by hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several fixes that I ran into while trying to make the
rubyonrailsexample pass the test.I also ran into postgres unix socket path being too long, but that's already covered by #1008.