Merge pull request #1076 from schneider-felix/fix-mysql-scripts

Pass command line arguments to mysql scripts
cachix · Apr 1, 2024 · c82b8ba · c82b8ba
2 parents 76e2f35 + 6c88af5
commit c82b8ba
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/src/modules/services/mysql.nix b/src/modules/services/mysql.nix
@@ -293,11 +293,17 @@ in
         MYSQL_TCP_PORT = toString cfg.settings.mysqld.port;
       });
 
-    scripts.mysql.exec = "${mysqlWrapped}/bin/mysql";
+    scripts.mysql.exec = ''
+      ${mysqlWrapped}/bin/mysql "$@"
+    '';
 
-    scripts.mysqladmin.exec = "${mysqladminWrapped}/bin/mysqladmin";
+    scripts.mysqladmin.exec = ''
+      ${mysqladminWrapped}/bin/mysqladmin "$@"
+    '';
 
-    scripts.mysqldump.exec = "${mysqldumpWrapped}/bin/mysqldump";
+    scripts.mysqldump.exec = ''
+      ${mysqldumpWrapped}/bin/mysqldump "$@"
+    '';
 
     processes.mysql.exec = "${startScript}/bin/start-mysql";
     processes.mysql-configure.exec = "${configureScript}/bin/configure-mysql";

diff --git a/tests/mysql/.test.sh b/tests/mysql/.test.sh
@@ -1,6 +1,14 @@
+set -e
+
 wait_for_port 3306
+
+# Wait for configure-mysql to finish.
+sleep 5
+
 # through unix_socket
 mysql -e 'SELECT VERSION()'
 
 # through tcp/ip
-mysql -h 127.0.0.1 -udb -pdb -e 'SELECT VERSION()'
+mysql -h "127.0.0.1" -udb -pdb -e 'SELECT VERSION()'
+
+ping-mysql
diff --git a/tests/mysql/devenv.nix b/tests/mysql/devenv.nix
@@ -16,4 +16,8 @@
       };
     };
   };
+
+  scripts.ping-mysql.exec = ''
+    $DEVENV_PROFILE/bin/mysqladmin ping
+  '';
 }