Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): Added a migration to set user preferred locale value #254

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

RoyHridoy
Copy link
Contributor

This PR resolves #249

When a user registers first, by default in the users table preferred_locale is set as NULL. Therefore if we set default() in select form component it would not work unless the user clicks the save changes button. The same result if we change in config.

Therefore, according to my perspective, to set English as the default language, we should do it when creating a user at the database level. That's why I added this migration.

After adding migration

default behavior 1

default behavior 2

@jbrooksuk jbrooksuk merged commit ed3990a into cachethq:main Mar 2, 2025
31 checks passed
@jbrooksuk
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong default language in dashboard (w/ workaround)
2 participants