Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-880 - Unauthorised organisation access fixed #961

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

maciej-goaco
Copy link
Collaborator

No description provided.

@@ -67,4 +69,25 @@ protected override async Task HandleRequirementAsync(AuthorizationHandlerContext

context.Fail();
}

private Guid? GetOrganisationId()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily copied over from UserInfoService which can't be injected.
Agreed to refactor on the next day with a comprehensive, global solution for accessing User.

Copy link
Member

@jakzal jakzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the condition we will revisit the approach and add tests

@jakzal
Copy link
Member

jakzal commented Nov 20, 2024

Merging. It will be tested on dev.

@jakzal jakzal merged commit 20913a1 into main Nov 20, 2024
8 checks passed
@jakzal jakzal deleted the feature/dp-880 branch November 20, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants