dp-866 One login error logging #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jakzal
approved these changes
Nov 18, 2024
mareg
requested changes
Nov 18, 2024
| if (context.Exception is InvalidOperationException invalidOpException && | ||
| invalidOpException.Message.Contains("Correlation failed")) | ||
| { | ||
| logger.LogError("Correlation failed. State: {State}", context.ProtocolMessage?.State); |
There was a problem hiding this comment.
Can you log an error with a single entry rather than multiple log errors? e.g. by passing context information?
There was a problem hiding this comment.
I have updated the code @mareg
shilpigoel-goaco
approved these changes
Nov 18, 2024
dpatel017
approved these changes
Nov 18, 2024
Frontend/CO.CDP.OrganisationApp/Authentication/OidcEvents.cs
Dismissed
Show dismissed
Hide dismissed
Frontend/CO.CDP.OrganisationApp/Authentication/OidcEvents.cs
Dismissed
Show dismissed
Hide dismissed
mareg
reviewed
Nov 19, 2024
mareg
approved these changes
Nov 19, 2024
Frontend/CO.CDP.OrganisationApp/Authentication/OidcEvents.cs
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dp-866 One login error logging